Skip to content

[4.0] Name translation: Allow type name translation when cursor points to constructor call. rdar://33163114 #10882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

nkcsgexi
Copy link
Contributor

  • Explanation: This change allows us to translate type names from Swift to Objc and vice versa by referring only to the constructor calls of that type.
  • Scope: Cross-language rename refactoring
  • Radar: rdar://33163114
  • Risk: Very Low
  • Testing: Regression test added

@nkcsgexi nkcsgexi added this to the Swift 4.0 milestone Jul 11, 2017
@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 71ae175
Test requested by - @nkcsgexi

@nkcsgexi
Copy link
Contributor Author

Foundation/NSRange.swift:264:29: error: value of type 'String.CharacterView.Index' has no member 'encodedOffset'
13:08:15 location: r.lowerBound.encodedOffset - target.startIndex.encodedOffset,
13:08:15 ~~^~~~~~~~~~ ~~~~~~~~~~~~~
13:08:15 [213/324] CompileSwift: Foundation/DateFormatter.swift
13:08:15 [214/324] CompileSwift: Foundation/NSSortDescriptor.swift

@bob-wilson
Copy link
Contributor

What's up with that Linux failure?

@nkcsgexi
Copy link
Contributor Author

It doesn't seem to be related to this change. Let's try running the test again. @swift-ci Please test Linux platform

@nkcsgexi
Copy link
Contributor Author

@bob-wilson The linux failure is gone after re-run.

@nkcsgexi nkcsgexi merged commit c903b20 into swiftlang:swift-4.0-branch Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants