Sema: Explicitly infer requirements from subscript element type for materializeForSet [4.0] #10910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aterializeForSet The interface type for materializeForSet does not mention the element type of a subscript, so Sema was not inferring requirements that were implied by the element type but not explicitly stated in the generic signature. This led to assertion failures in SILGen because the materializeForSet calls the getter and setter, which does have these requirements. Fixes <rdar://problem/33219034>, <https://bugs.swift.org/browse/SR-5420>.
|
@swift-ci Please test |
|
(Ted approved this but forgot to merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes a SILGen assertion failure when compiling a generic subscript where some of the requirements on the generic signature are inferred from the element type. We were not computing the generic signature of the materializeForSet accessor properly in this case.
Scope of the issue: If the requirement is explicitly stated, it works, but then we emit a warning telling the user to remove it. Reported externally
Origination: Generic subscripts are a new feature in 4.0
Tested: New test added
Reviewed by: @DougGregor
Radar: rdar://problem/33219034