[swift-4.0-branch][overlay] Port Foundation String extensions to StringProtocol #10947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moiseev
commented
Jul 13, 2017
moiseev
commented
- Explanation: Currently most string extensions in Foundation are on String, which renders them unavailable on Substring. This is a bad user experience, because some of those extensions are quite useful. This change ports these extensions to StringProtocol instead.
- Scope of Issue: Enables String extensions on Substring.
- Risk: minimal
- Reviewed By: Dave Abrahams
- Testing: Automated test suite
- Directions for QA: N/A
- Radar: rdar://problem/32777093
(cherry picked from commit eb04df4)
(cherry picked from commit b2b0dc4)
(cherry picked from commit f45c188)
(cherry picked from commit fe1ebdf)
(cherry picked from commit fc0cf33)
(cherry picked from commit 5f1c3f7)
(cherry picked from commit 72479ac)
…xtensions (cherry picked from commit 77edc65)
(cherry picked from commit 1a0436e)
|
@swift-ci Please test |
|
@swift-ci Please Test Source Compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.