[stdlib] Fix array slice self-assignment bug #10958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned slice matched
|
@swift-ci please test |
jrose-apple
reviewed
Jul 14, 2017
dabrahams
requested changes
Jul 14, 2017
|
@swift-ci please test and merge |
airspeedswift
added a commit
to airspeedswift/swift
that referenced
this pull request
Jul 17, 2017
Fix bug where assigning from self wasn't checking bounds of the assigned slice matched
airspeedswift
added a commit
that referenced
this pull request
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SR-4503.
In-place mutation of an array slice doesn't need assigning back, but there needs to be a check that the assigned slice's bounds matches otherwise unmatched range assignments like
a[1..<1] = a[1..<2]were getting thrown away.