Skip to content

[QoI] Improve fix-it when renamed method has contextual member lookup argument #10962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2017

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jul 14, 2017

Currently we generate incorrect fix-it in situations where we
have contextual member lookup as one of the arguments.

Resolves: rdar://problem/32526620

@xedin
Copy link
Contributor Author

xedin commented Jul 14, 2017

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Jul 14, 2017

/cc @rudkx This affects migrator, do you think it's worth getting in 4.0 as well?

@xedin xedin requested a review from rudkx July 14, 2017 08:15
@xedin
Copy link
Contributor Author

xedin commented Jul 14, 2017

@swift-ci please smoke test

Copy link
Contributor

@rudkx rudkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and yes let's try to get this into the 4.0 branch.

… argument

Currently we generate incorrect fix-it in situations where we
have contextual member lookup as one of the arguments.

Resolves: rdar://problem/32526620
@xedin
Copy link
Contributor Author

xedin commented Jul 14, 2017

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 00629d5 into swiftlang:master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants