Skip to content

[stdlib] Utilize '#if' for switch cases in HashedCollections #10966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 14, 2017

_Cocoa{Set,Dictionary}{Buffer,Index,Iterator} can be completely eliminated from non-ObjC runtime environments.

_Cocoa{Set,Dictionary}{Buffer,Index,Iterator} can be completely
eliminated from non-ObjC runtime environments.
@rintaro
Copy link
Member Author

rintaro commented Jul 14, 2017

@swift-ci Please test

@rintaro rintaro closed this Jul 14, 2017
@rintaro rintaro reopened this Jul 14, 2017
@moiseev
Copy link
Contributor

moiseev commented Jul 16, 2017

@rintaro Why was it closed and reopened again? Is it OK to merge?

@rintaro
Copy link
Member Author

rintaro commented Jul 16, 2017

@moiseev
It was just an accidental close/reopen.
I'm OK to merge this.

@rintaro
Copy link
Member Author

rintaro commented Jul 16, 2017

If SE-0154 is going to be implemented in Swift4.0, probably we should hold off this PR.

#if for switch case feature hasn't been taken into swift-4.0-branch #9457

@rintaro
Copy link
Member Author

rintaro commented Jul 21, 2017

Ah, I didn't know SE-0154 has already been implemented in #9030
If it's stable, I think we can merge this PR.
@natecook1000 Any concern?

@natecook1000
Copy link
Member

No concerns on my end!

@rintaro
Copy link
Member Author

rintaro commented Jul 24, 2017

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 4d5dfdd into swiftlang:master Jul 24, 2017
@rintaro rintaro deleted the stdlib-hashedcollection-switchcase branch July 25, 2017 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants