Skip to content

[stdlib/Foundation] Swift 3 backward compatibility hack #10970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2017
Merged

Conversation

dabrahams
Copy link
Contributor

Since samePosition(in:) now unconditionally returns optionals,
String.UTF16View.Index.distance(to: String.UTF16View.Index) must accept an
optional to keep some code working.

Fixes rdar://33307780.

@dabrahams
Copy link
Contributor Author

@swift-ci Please test and merge

@dabrahams
Copy link
Contributor Author

@swift-ci Please test Linux Platform

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 3b250fba15c859ca2c43bb94f01d5e64777a3947
Test requested by - @dabrahams

@dabrahams
Copy link
Contributor Author

@swift-ci Please smoke test Linux Platform

@dabrahams
Copy link
Contributor Author

@swift-ci Please test

@dabrahams
Copy link
Contributor Author

@swift-ci Please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - f523a30349e0e563268e9507e742e34fb8a1a189
Test requested by - @dabrahams

Dave Abrahams added 2 commits July 14, 2017 15:30
Since samePosition(in:) now unconditionally returns optionals,
String.UTF16View.Index.distance(to: String.UTF16View.Index) must accept an
optional to keep some code working.

Fixes <rdar://33307780>.
Otherwise, the result would have been an infinite recursion.
@dabrahams
Copy link
Contributor Author

@swift-ci Please test and merge

@swift-ci swift-ci merged commit efb7d75 into master Jul 15, 2017
@dabrahams dabrahams deleted the rdar-33307780 branch July 15, 2017 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants