Skip to content

[NFC] Remove Syntax's dependency on Sema #10984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2017
Merged

[NFC] Remove Syntax's dependency on Sema #10984

merged 3 commits into from
Jul 18, 2017

Conversation

harlanhaskins
Copy link
Contributor

This patch removes Semantics.cpp of libSyntax from Sema and into AST. It also moves LegacyASTTransformer, the only user of Sema/Semantics into AST.

This ensures the dependency graph looks like this:

    Syntax
   /  |
  |  AST
   \  | 
    Parse
      |
     Sema

@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test

jrose-apple
jrose-apple approved these changes Jul 15, 2017
View reviewed changes
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Harlan!

@harlanhaskins
Copy link
Contributor Author

Will squash and merge once CI passes. 👍

@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test and merge

@harlanhaskins
Copy link
Contributor Author

That test failure is not mine. Looks like it might be @CodaFi’s inout changes?

@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test and merge

@harlanhaskins
Copy link
Contributor Author

That failure is also unrelated – this is related to the weird failures we’ve been seeing the past few days 😕

@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test and merge

@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test and merge

1 similar comment
@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test and merge

@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test and merge

@harlanhaskins
Copy link
Contributor Author

@swift-ci please smoke test

@harlanhaskins
Copy link
Contributor Author

⛵️

@harlanhaskins harlanhaskins merged commit b9f468e into swiftlang:master Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harlanhaskins @jrose-apple