Change typeCheckExpression() to return Type. #10999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
|
This introduces a tri-state, is that intentional? It seems like we should bail with |
|
Yes, true. Type() is not a valid type-checked value, so it would make more sense to use that to indicate failure. |
Doing this allows us to return ErrorType in some circumstances where we want to communicate that we don't have a usable type rather than writing ErrorType directly into the type of the expression root, avoiding a mutation of the expression tree in a failure case.
rudkx
changed the title
|
@swift-ci Please smoke test |
CodaFi
reviewed
Jul 17, 2017
| @@ -1562,14 +1562,15 @@ class TypeChecker final : public LazyResolver { | |||
| /// otherwise | |||
| /// | |||
| /// \returns true if an error occurred, false otherwise. | |||
There was a problem hiding this comment.
Nit: It Would Be Nice™ to update this in a later commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this allows us to return ErrorType in some circumstances where we
want to communicate that we don't have a usable type rather than writing
ErrorType directly into the type of the expression root, avoiding a
mutation of the expression tree in a failure case.