[QoI] Improve diagnostics for assignment expression #11042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
force-pushed
the
rdar-32711708
branch
4 times, most recently
from
d3207cd to
68c22bb
Compare
xedin
force-pushed
the
rdar-32711708
branch
2 times, most recently
from
aab8772 to
0359499
Compare
Currently `visitAssignExpr` always attempts to use type derived from destination as a contextual type for assignment source type-checking, which doesn't always lead to better results. Resolves: SR-5081
|
@swift-ci please smoke test |
xedin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
visitAssignExpralways attempts to use typederived from destination as a contextual for assignment
source type-checking, which doesn't always lead to better
results.
Resolves SR-5081.