Skip to content

[4.0] [QoI] Fix position of the fix-it related to raw representable conversion #11051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jul 19, 2017

  • Description: Part of the fix-it for conversion from optional to raw representable
    was inserted at the incorrect position which produces invalid expression.

  • Scope of the issue: Fix positioning for the fix-it related to optional to raw representable conversion.

  • Origination: Diagnostic improvement previously merged into 4.0 introduced a fix-it which was partially incorrect.

  • Risk: Low.

  • Tested: Updated related tests, Swift CI.

  • Reviewed by: Mark Lacey.

  • Resolves: rdar://problem/32431736
    (cherry picked from commit 2bec75e)

Part of the fix-it for conversion from optional to raw representable
was inserted at the incorrect position which produces invalid expression.

Resolves: rdar://problem/32431736
(cherry picked from commit 2bec75e)
@xedin xedin added this to the Swift 4.0 milestone Jul 19, 2017
@xedin xedin requested a review from rudkx July 19, 2017 06:21
@xedin
Copy link
Contributor Author

xedin commented Jul 19, 2017

@swift-ci please test

@xedin xedin merged commit e492a37 into swiftlang:swift-4.0-branch Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant