Skip to content

Remove SwiftExperimental #11087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2017
Merged

Remove SwiftExperimental #11087

merged 1 commit into from
Aug 18, 2017

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jul 20, 2017 •
edited
Loading

See here for discussion. This should not be merged until we come to a consensus about what to do with this library.

@CodaFi CodaFi added the swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review label Jul 20, 2017
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 20, 2017

@swift-ci please clean test

@CodaFi CodaFi requested review from dabrahams and moiseev July 20, 2017 20:49
@moiseev moiseev requested a review from airspeedswift July 20, 2017 21:06
@CodaFi
Copy link
Contributor Author

CodaFi commented Aug 11, 2017

Internal consensus is that the target should be removed but the operators distributed into parse/typechecking tests.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 826b7e074208b8ab147f6cf71b5019daa64f0241

@CodaFi CodaFi force-pushed the a-farewell-to-grant-money branch from 826b7e0 to e4bfd60 Compare August 11, 2017 21:21
@CodaFi
Copy link
Contributor Author

CodaFi commented Aug 11, 2017

@swift-ci please clean test

moiseev
moiseev approved these changes Aug 11, 2017
View reviewed changes
Copy link
Contributor

@moiseev moiseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CodaFi CodaFi changed the title [DO NOT MERGE] Remove SwiftExperimental Remove SwiftExperimental Aug 11, 2017
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e4bfd60

@jessesquires jessesquires mentioned this pull request Aug 12, 2017
Closed
dabrahams
dabrahams approved these changes Aug 12, 2017
View reviewed changes
Copy link
Contributor

@dabrahams dabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming some consensus was reached about what to do with the code, and @moiseev approves, so do I.

@CodaFi CodaFi removed the swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review label Aug 18, 2017
@CodaFi
Copy link
Contributor Author

CodaFi commented Aug 18, 2017

Thanks all!

⛵️

@CodaFi
Copy link
Contributor Author

CodaFi commented Aug 18, 2017

@swift-ci please test and merge

@swift-ci swift-ci merged commit 94dccf1 into swiftlang:master Aug 18, 2017
@RomanVolkov RomanVolkov mentioned this pull request Aug 18, 2017
Closed
@CodaFi CodaFi deleted the a-farewell-to-grant-money branch August 18, 2017 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabrahams dabrahams dabrahams approved these changes

@moiseev moiseev moiseev approved these changes

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CodaFi @swift-ci @dabrahams @moiseev @airspeedswift