[4.0] Don't consider KeyPathApplication operations when looking up non-SubscriptExprs. #11089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them. Assertions tripped while trying to reproduce SR-5513.
…iptExprs. Interactions with the rest of the type checker cause use of functions named `subscript` with backtick-quotes to become ambiguous. This is more fully and robustly solved in master by swiftlang#9989, but that's too invasive a change for 4.0, and we need a spot fix to prevent source compatibility regressions such as SR-5513.
|
@xedin Does this look ok for 4.0? |
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Introducing the global key path subscript operation introduced an ambiguity bug for code that tried to reference functions named
subscript(using backtick quoted identifiers). This is fixed more deeply on master by #9989; this is a focused compatibility fix for 4.0.Scope: Source compatibility regression; impacts ability to use AppKit because
NSTexthas a-subscript:action.Issue: SR-5513 | rdar://problem/33413614
Risk: Low, targeted bug fix
Testing: Swift CI, example from Jira