Skip to content

[swift-4.0-branch][stdlib] Remove DoubleWidth<T> #11141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jul 24, 2017

  • Explanation: DoubleWith type is partially implemented in the Integers.swift.gyb. The complete implementation has been merged into master in this PR: [stdlib] DoubleWidth Implementation #9367
    It, however, increased the size of the stdlib binary produced, which is unlikely to be addressed in the time left until the release.
  • Scope of Issue: Removing the unused and, in fact, unusable code.
  • Risk: Minimal
  • Reviewed By: Ben Cohen
  • Testing: Automated test suite
  • Directions for QA: N/A
  • Radar: rdar://problem/33493257

<rdar://problem/33493257>
@moiseev
Copy link
Contributor Author

moiseev commented Jul 24, 2017

@swift-ci Please test

@airspeedswift airspeedswift merged commit 7b33533 into swiftlang:swift-4.0-branch Jul 24, 2017
@moiseev moiseev deleted the remove-doublewidth-4 branch July 24, 2017 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants