[4.0] NSNumber custom AnyHashable fix #11152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 24, 2017 16:05
When we give NSNumber a custom AnyHashable representation, we want to give it as large a box as possible. When we want to compare it against other AnyHashable boxes such as Int or UInt, it's always possible to upcast the Int/UInt to a larger integer size like Int64 or UInt64 for the comparison. By eliminating the smaller boxes we create, we can maintain the existing behavior that _SwiftTypePreservingNSNumber gave us.
|
@swift-ci Please test macOS |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #11138 to
swift-4.0-branch.Explanation: Resolves rdar://problem/33105735.
When we give
NSNumbera customAnyHashablerepresentation, we want to give it as large a box as possible. When we want to compare it against otherAnyHashableboxes such asIntorUInt, it's always possible to upcast theInt/UIntto a larger integer size likeInt64orUInt64for the comparison. By eliminating the smaller boxes we create, we can maintain the existing behavior that_SwiftTypePreservingNSNumbergave us.Scope: Affects
NSDictionarybridging with numeric keysRadar: rdar://problem/33105735
Risk: Low
Testing: Adds unit tests to confirm expected behavior.