[swift-4.0-branch][stdlib] Implement BinaryInteger.words #11156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moiseev
commented
Jul 24, 2017
moiseev
commented
- Explanation: Implements words property on integer types as part of SE-0104 implementation.
- Scope of Issue: Removes the underscored APIs and instead implements the words collection properly.
- Risk: Minimal
- Reviewed By: Dave Abrahams
- Testing: Automated test suite
- Directions for QA: N/A
- Radar: rdar://problem/33292169
Removes BinaryInteger's _word(at:) requirement and its countOfRepresentedWords property, making the words property the sole way to access an integer's words. This is a better fix for https://bugs.swift.org/browse/SR-5275. (cherry picked from commit c8d4fd4)
(cherry picked from commit 6ae2040)
(cherry picked from commit 826f8da)
(cherry picked from commit 0246ef1)
(cherry picked from commit 46dc04f)
(cherry picked from commit 1dccb45)
We don’t need Words’ members to be @_transparent; simple conversions use _lowWord instead. (cherry picked from commit e975445)
This fixes integer conversion issues on 32-bit platforms. (cherry picked from commit 735fe97)
This adds 8 more collection views, but makes integer definitions more consistent across all the available bit widths and between 32-bit and 64-bit platforms. (cherry picked from commit 9996d07)
|
@swift-ci Please test |
|
@swift-ci Please Test Source Compatibility |
|
/cc @lorentey, @airspeedswift |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.