IRGen: Fix partial applies of generic functions capturing the generic parameters in an argument #11172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parameters in an argument The code assumed if there is no context object but rather the captured argument is reused as the context object that the parameter index for this argument is going to be the last one. This is not true if there are empty types in the parameter list. rdar://33502272
|
@swift-ci Please test |
|
LGTM. |
|
Build failed |
|
The OS X failure is unrelated to this commit. It exists also here: https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-simulator/3445/ |
|
I talked to @shajrawi and he confirmed that this failure is very likely his and he will fix it soon. |
|
@aschwaighofer I changed the watch-target test-case label as part of this PR #11182 - smoke testing it now - hopefully that should do it |
|
@swift-ci Please test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assumed if there is no context object but rather the captured argument
is reused as the context object that the parameter index for this argument is
going to be the last one. This is not true if there are empty types in the
parameter list.
rdar://33502272