[GSB] SE-0157: Reprocess delayed requirements when we need a complete PA #11174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PA. Whenever we need a complete, well-formed potential archetype, reprocess any delayed requirements, so that we pick up additional requirements on that potential archetype. This relies on us tracking a generation count for the GSB instance as a whole, which gets bumped each time we add some new requirement or create a new potential archetype, and only actually reprocessing delayed requirements when the generation count exceeds the point at which we last processed delayed requirements. This gets the most basic recursive protocol constraint working end-to-end and doesn't seem to break things.
When determining whether a conformance requirement source is self-derived, ignore the top-level "Self: P" requirement in a requirement signature. Fixes SR-5485 / rdar://problem/33360699.
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we need a complete, well-formed potential archetype,
reprocess any delayed requirements, so that we pick up additional
requirements on that potential archetype.
This relies on us tracking a generation count for the GSB instance as
a whole, which gets bumped each time we add some new requirement or
create a new potential archetype, and only actually reprocessing
delayed requirements when the generation count exceeds the point at
which we last processed delayed requirements.
This gets the most basic recursive protocol constraint working
end-to-end. The actual improvements are gated on the
-enable-recursive-constraintsflag because the reprocessing causes type-checker performance issues.