Skip to content

[Clang importer] Map swift_objc_members attribute found on superclasses. #11183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2017
Merged

[Clang importer] Map swift_objc_members attribute found on superclasses. #11183

merged 1 commit into from
Jul 26, 2017

Conversation

DougGregor
Copy link
Member

Fixes rdar://problem/33514802.

@DougGregor DougGregor requested a review from jrose-apple July 25, 2017 23:19
@DougGregor
Copy link
Member Author

@swift-ci please smoke test and merge

jrose-apple
jrose-apple reviewed Jul 25, 2017
View reviewed changes
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not happy about this, but it's reasonable for a narrow 4.0 fix. Please do file a follow-up to consider a Clang-side fix instead.

@DougGregor DougGregor merged commit 37a3d85 into swiftlang:master Jul 26, 2017
@DougGregor DougGregor deleted the swift-objc-members-inherited branch July 26, 2017 05:15
@DougGregor
Copy link
Member Author

Filed the Clang-side radar as rdar://problem/33542554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @jrose-apple