[silgen] Assert that rvalues always have consistent ownership and cle… #11195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
|
Actually, I want to do a full test... Hmm... |
…anups. This means that all non-trivial ManagedValues must: 1. All have a cleanup or all not have a cleanup. 2. Have the same ValueOwnershipKind. Semantic SIL requires this of tuple values. So it makes sense to catch this bug as early as possible. rdar://33358110
gottesmm
force-pushed
the
rvalues_should_have_consistent_ownership
branch
from
3648d73 to
7bad324
Compare
|
There we go. |
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…anups.
This means that all non-trivial ManagedValues must:
Semantic SIL requires this of tuple values. So it makes sense to catch this bug
as early as possible.
rdar://33358110