Skip to content

Ensure RawSyntax macro parameters are the same with NDEBUG #11196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2017
Merged

Ensure RawSyntax macro parameters are the same with NDEBUG #11196

merged 1 commit into from
Jul 26, 2017

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jul 26, 2017 •
edited
Loading

(@harlanhaskins committing with @CodaFi's account -- thanks!)

I forgot to reset the macro parameters after converting them to
varargs, which didn't get caught running PR testing.

This patch ensures they're all the same, and fixes the bots.

rdar://33531765

Ensure RawSyntax macro parameters are the same with NDEBUG
87fc684 
I forgot to reset the macro parameters after converting them to
varargs, which didn't get caught running PR testing.

This patch ensures they're all the same.
@CodaFi CodaFi requested a review from swiftix July 26, 2017 05:44
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 26, 2017

preset=buildbot,tools=RD,stdlib=RD
@swift-ci Please test with preset

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 26, 2017

@swift-ci please smoke test

@shahmishal
Copy link
Member

preset=buildbot,tools=RD,stdlib=RD
@swift-ci Please test with preset

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test macOS with preset
Git Commit - 87fc684
Test requested by - @shahmishal

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 26, 2017

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test with preset

1 similar comment
@shahmishal
Copy link
Member

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test with preset

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test macOS with preset
Git Commit - 87fc684
Test requested by - @shahmishal

@harlanhaskins
Copy link
Contributor

Not quite sure why this failed. It built successfully, but Build step 'Publish xUnit test result report' changed build result to FAILURE

@harlanhaskins
Copy link
Contributor

@swiftix The build succeeded and all the tests passed, but the bot failed creating an installable package somehow. Think this is good to merge to get the bots building again?

@swiftix
Copy link
Contributor

swiftix commented Jul 26, 2017

@harlanhaskins Yeah, the installable package failure seems unrelated. It should be fine to merge it.

@harlanhaskins
Copy link
Contributor

⛵

@harlanhaskins harlanhaskins merged commit 481715a into swiftlang:master Jul 26, 2017
@CodaFi CodaFi deleted the de-bug-the-non-debug-build branch July 26, 2017 17:19
@shahmishal
Copy link
Member

@harlanhaskins Fixed :)

Not quite sure why this failed. It built successfully, but Build step 'Publish xUnit test result report' changed build result to FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiftix swiftix Awaiting requested review from swiftix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CodaFi @shahmishal @swift-ci @harlanhaskins @swiftix