[4.0] [SE-0182][Lexer] Diagnose escaped newline at the end of the last line in multiline string #11204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in multiline string (cherry picked from commit a2d3ff4)
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test OSX |
1 similar comment
|
@swift-ci please clean test OSX |
|
@swift-ci please clean test OS X |
|
Build failed |
|
sigh, the test machine disconnected |
|
@swift-ci please test OS X |
1 similar comment
|
@swift-ci please test OS X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Follow-on for the implementation of SE-0182 (escaped newlines in multiline string literals) that diagnoses escaped newlines at the end of a multiline string literal.
Scope: Minor tightening of a feature that is new in Swift 4 and hasn't gone out in a beta yet.
Radar: rdar://problem/33548820
Risk: Effectively zero.
Reviewed By: @rintaro implemented it, I reviewed it
Testing: Compiler regression tests