When creating destroys for addresses passed into a partial apply, fir… #11230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
…st move the values into a stack location with a live range that is guaranteed to be larger than the partial apply's live range. Otherwise, we may insert destroy_addrs on alloc_stack whose lifetimes have ended. rdar://33502257
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
gottesmm
commented
Jul 28, 2017
| // CHECK-NEXT: destroy_addr [[ARG1]] | ||
| // CHECK-NEXT: apply [[FN]]<T, T>([[ARG0]], [[TMP]]) |
There was a problem hiding this comment.
In case anyone looks at this and wonders why this changed, it is b/c our (apply (partial_apply)) -> (partial_apply) (apply') uses the dead partial_apply code to clean up. This is disguised by the optimization that gets rid of trivially dead live ranges. I added a version of this test to the sil_combine_array.sil test (see below) that takes advantage of that optimization being disabled in that file. So it is not as cleaned up and the work being done is obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st move the values into a stack location with a live range that is guaranteed to be larger than the partial apply's live range.
Otherwise, we may insert destroy_addrs on alloc_stack whose lifetimes have
ended.
rdar://33502257