Skip to content

[swift-4.0-branch] Implement SE-0104 changes #11232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 28, 2017
Merged

[swift-4.0-branch] Implement SE-0104 changes #11232

merged 6 commits into from
Jul 28, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jul 27, 2017 •
edited
Loading

  • Explanation: Implement changes from the latest revision of SE-0104
  • Scope of Issue: Improves the API of built-in integer types
  • Risk: Minimal
  • Reviewed By: Max Moiseev, Dave Abrahams
  • Testing: Automated test suite
  • Directions for QA: N/A
  • Radar: rdar://problem/33555603

Dave Abrahams and others added 4 commits July 27, 2017 14:34
[stdlib] Rationalize bitshifting in protocols
1bf8e41 
Only FixedWidthInteger, not BinaryInteger, should have masking shifts.
BinaryInteger should have a non-masking shift requirement.

Removed some dead code.

Ported the endianness-related changes from master.

(cherry picked from commit 33e9ec4)
[stdlib] init<T : FloatingPoint> ==> init<T : BinaryFloatingPoint>
a47932b 
(cherry picked from commit 5d47a0d)
[stdlib] Get rid of ArithmeticOverflow type
a138cca 
(cherry picked from commit 1c3e597)
[test] Fix validation tests
0424234 
(cherry picked from commit 5da3e1d)
@moiseev
Copy link
Contributor Author

moiseev commented Jul 27, 2017

swiftlang/swift-corelibs-foundation#1136
swiftlang/swift-package-manager#1289
@swift-ci Please test

@moiseev
Copy link
Contributor Author

moiseev commented Jul 27, 2017

swiftlang/swift-corelibs-foundation#1136
swiftlang/swift-package-manager#1289
@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 0424234
Test requested by - @moiseev

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 0424234
Test requested by - @moiseev

@moiseev
Copy link
Contributor Author

moiseev commented Jul 27, 2017

swiftlang/swift-corelibs-foundation#1136
swiftlang/swift-package-manager#1289
@swift-ci Please test

@moiseev moiseev force-pushed the integers-revised-4 branch from 0149020 to ccd4c98 Compare July 27, 2017 23:54
@swiftlang swiftlang deleted a comment from swift-ci Jul 27, 2017
@swiftlang swiftlang deleted a comment from swift-ci Jul 27, 2017
@moiseev
Copy link
Contributor Author

moiseev commented Jul 27, 2017

swiftlang/swift-corelibs-foundation#1136
swiftlang/swift-package-manager#1289
@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 0149020ec6d9088f8ff71810808b6bf76fd984de
Test requested by - @moiseev

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 0149020ec6d9088f8ff71810808b6bf76fd984de
Test requested by - @moiseev

@moiseev
Copy link
Contributor Author

moiseev commented Jul 28, 2017

swiftlang/swift-package-manager#1289
@swift-ci Please clean test macOS

@moiseev moiseev merged commit 19d2953 into swiftlang:swift-4.0-branch Jul 28, 2017
@moiseev moiseev deleted the integers-revised-4 branch July 28, 2017 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moiseev @swift-ci