[4.0] When creating destroys for addresses passed into a partial apply, fir… #11240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st move the values into a stack location with a live range that is guaranteed to be larger than the partial apply's live range. Otherwise, we may insert destroy_addrs on alloc_stack whose lifetimes have ended. rdar://33502257 (cherry picked from commit 81914b9)
|
@swift-ci test |
|
@eeckstein I decided to go with the route that we originally discussed: put the alloc_stack at the beginning/end of the function, but just not process partial_applies that have arguments with dependent types. |
|
Explanation: We were not properly extending the live range of an alloc_stack when we were eliminating dead partial_applies. This fix ensures that we do do so. Without this patch we run into use-after frees as a result of the bad live range. |
|
Approved by Ted via email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st move the values into a stack location with a live range that is guaranteed to be larger than the partial apply's live range.
Otherwise, we may insert destroy_addrs on alloc_stack whose lifetimes have
ended.
rdar://33502257
(cherry picked from commit 81914b9)