Skip to content

[gardening] Fix typos #11245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 28, 2017
Merged

[gardening] Fix typos #11245

merged 10 commits into from
Jul 28, 2017

Conversation

koogawa
Copy link
Contributor

@koogawa koogawa commented Jul 28, 2017

  • getTopLeveDecls -> getTopLevelDecls
  • silModue -> silModule
  • Evaludate -> Evaluate
  • OptioanlPayload -> OptionalPayload
  • confromance -> conformance
  • chcking -> checking
  • settting -> setting
  • tpye -> type
  • resoved -> resolved
  • ahve -> have ? 🤔

@alblue
Copy link
Contributor

alblue commented Jul 28, 2017

These look good to me. Everything is comment based apart from ed8c4d0 which is changing a local variable name, and all of the references seem to have been captured.

@koogawa
Copy link
Contributor Author

koogawa commented Jul 28, 2017

@alblue OK, I reverted ed8c4d0

@CodaFi
Copy link
Contributor

CodaFi commented Jul 28, 2017

Going to squash this on my end.

⛵️

@swift-ci please smoke test

@CodaFi CodaFi merged commit 2a18723 into swiftlang:master Jul 28, 2017
@CodaFi
Copy link
Contributor

CodaFi commented Jul 28, 2017

Thanks!

@practicalswift
Copy link
Contributor

Wow! Excellent gardening work @koogawa. Please keep it coming! :-)

@alblue
Copy link
Contributor

alblue commented Jul 28, 2017

Yeah, great work @koogawa. By the way, my comment regarding the silModue typo wasn't that it shouldn't be merged, just that if @CodaFi or others were to review the patch they might have wanted to double check that particular change. The rename looked safe to me, so I hadn't intended that you roll that back necessarily :-)

@koogawa koogawa deleted the fix-typos branch July 28, 2017 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants