Skip to content

[4.0] Mark _AppendKeyPath as visible in interface #11246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2017
Merged

[4.0] Mark _AppendKeyPath as visible in interface #11246

merged 1 commit into from
Jul 28, 2017

Conversation

natecook1000
Copy link
Member

This is a cherry pick of #11233.

  • Explanation: Adds the @_show_in_interface attribute to the _AppendKeyPath protocol. This allows the appending(path:) methods to appear in the generated interface and downstream documentation.
  • Scope: This has no functional change beyond changing the visibility of the _AppendKeyPath protocol.
  • Radar/SR: rdar://problem/33592582
  • Risk: Very Low
  • Testing: Unit and validation tests.

@natecook1000 natecook1000 requested a review from jckarter July 28, 2017 17:14
@natecook1000
Copy link
Member Author

@swift-ci Please test

@jckarter
Copy link
Contributor

LGTM, thanks Nate!

@natecook1000 natecook1000 merged commit e067279 into swiftlang:swift-4.0-branch Jul 28, 2017
@natecook1000 natecook1000 deleted the nc4-appendkeypath branch July 28, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natecook1000 @jckarter