Small crasher fixes #11265
Merged
Small crasher fixes #11265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
small-crasher-fixes
branch
from
6888769 to
3a9f55b
Compare
If the DeclContext's Self type-in-context is an ErrorType, we should still resolve generic parameters to interface types.
slavapestov
force-pushed
the
small-crasher-fixes
branch
from
3a9f55b to
bdaf226
Compare
I don't have reduced test cases. The original test cases were a series of frontend invocations in -parse-stdlib mode. While the original bugs seem to have been fixed, while verifying I found a few places where we weren't checking for null decls property in the ASTContext. Probably not too useful to check this in, but I don't see it causing any harm, either.
Recently TupleTypeElt was changed to add an inout bit. It is no longer valid to construct tuple types whose elements have InOutType, and instead the flag on the element must be set instead. Update diagnoseImplicitSelfErrors() for the new convention. Fixes the only remaining crash in the test case from <rdar://19569255>, but the original issue were fixed long ago.
Again, no test case -- this was an old radar with a -parse-stdlib example, and I'm just making this change to verify that the original crash was fixed.
slavapestov
force-pushed
the
small-crasher-fixes
branch
from
bdaf226 to
cb3dcbe
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bunch of internal radars with test cases generated by an unreleased stdlib fuzzer. Most of the original problems have since been fixed, but while verifying I found a few minor crashers. Some of the fixes don't have test cases because they're only possible to trigger in edge case diagnostics from stdlibs that are missing certain common declarations, such as
Int.