Skip to content

[code-completion] Generic where clauses #11267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2017

Conversation

benlangmuir
Copy link
Contributor

@benlangmuir benlangmuir commented Jul 31, 2017

Complete generic parameters and their members inside generic where
clauses on structs, classes, enums, extensions, typealiases, funcs,
subscripts and inits.

Still not handled correctly are where clauses on associatedtype decls.

rdar://problem/20582394

Complete generic parameters and their members inside generic where
clauses on structs, classes, enums, extensions, typealiases, funcs,
subscripts and inits.

Still not handled correctly are associatedtypes.

rdar://problem/20582394
@benlangmuir
Copy link
Contributor Author

There's some messiness here around calling setParsedDecl where I think we ought to instead be changing Parser.CurDeclContext in the where clause, but I'll look at that separately.

@benlangmuir
Copy link
Contributor Author

@swift-ci please smoke test

@benlangmuir
Copy link
Contributor Author

@swift-ci please smoke test macOS

@benlangmuir benlangmuir merged commit c55e07b into swiftlang:master Jul 31, 2017
@benlangmuir benlangmuir deleted the cc-generic-where-clause branch July 31, 2017 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant