Skip to content

Break docs/ABI.rst into a subdirectory of documents. #11271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2017

Conversation

jckarter
Copy link
Contributor

There's a lot of information here for one document, so I think another layer of organization is warranted. This commit only breaks up the existing content by heading, it does not update or otherwise change any content.

@jckarter jckarter requested review from milseman, rjmccall and atrick July 31, 2017 18:25
@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test

@jckarter
Copy link
Contributor Author

@rjmccall @milseman @atrick Any objections?

There's a lot of information here for one document, so I think another layer of organization is warranted. This commit only breaks up the existing content by heading, it does not update or otherwise change any content.
@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test

1 similar comment
@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test

@atrick
Copy link
Contributor

atrick commented Jul 31, 2017

👍 Thank you.

@jckarter jckarter merged commit 106f4be into swiftlang:master Jul 31, 2017
@bob-wilson
Copy link
Contributor

I'm seeing a failure on master-next after this change:

Warning, treated as error:
/Users/bwilson/local/master-next/src/oss/swift/docs/ABI/TypeMetadata.rst:149: ERROR: Unknown target name: "existential container layout".

@jckarter
Copy link
Contributor Author

@bob-wilson Thanks, #11278 should address that.

@CodaFi
Copy link
Contributor

CodaFi commented Aug 1, 2017

One more, #11280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants