Properly interpolate negative AP literals #11286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integer and Floating literals are aware of their negation but do not store the sign in the text of the value. Retrieve the sign bit and properly interpolate the text of the literal value with it to distinguish negative and positive literals.
|
@swift-ci please smoke test |
|
#11288 Will unblock the bots. |
|
@swift-ci please smoke test |
|
@swift-ci please test and merge |
jrose-apple
reviewed
Aug 2, 2017
| @@ -893,7 +893,7 @@ class IntegerLiteralExpr : public NumberLiteralExpr { | |||
| {} | |||
|
|
|||
| APInt getValue() const; | |||
| static APInt getValue(StringRef Text, unsigned BitWidth); | |||
| static APInt getValue(StringRef Text, unsigned BitWidth, bool Negative); | |||
There was a problem hiding this comment.
If you 're going to store a sign you should use APSInt.
|
|
||
| if (intExpr->isNegative()) | ||
| intValue = -intValue; | ||
| intType->getBitWidth(), |
There was a problem hiding this comment.
I don't remember offhand but I think you need an extra bit for the negative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integer and Floating literals are aware of their negation but
do not store the sign in the text of the value. Retrieve the
sign bit and properly interpolate the text of the literal value
with it to distinguish negative and positive literals.
Includes a bit of cleanup in IRGen too.