runtime: Fix overflow of swift_unownedRetain reference counts #11290
Conversation
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Unrelated error: |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
Build failed |
aschwaighofer
force-pushed
the
runtime_fix_unowned_retain_overflow
branch
2 times, most recently
from
ebba3dc to
9a75101
Compare
|
Build failed |
aschwaighofer
force-pushed
the
runtime_fix_unowned_retain_overflow
branch
from
9a75101 to
ada35ce
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
stdlib/public/SwiftShims/RefCount.h
Outdated
| // Check overflow and use the side table on overflow. | ||
| if (newbits.getUnownedRefCount() != oldValue + inc) | ||
| return incrementUnownedSlow(inc); | ||
|
|
||
| // FIXME: overflow check? |
There was a problem hiding this comment.
nitpick: you should remove the FIXME (maybe in a follow-up commit)
There was a problem hiding this comment.
Yes. I noticed it too. I am going to do it in a follow up.
aschwaighofer
force-pushed
the
runtime_fix_unowned_retain_overflow
branch
from
ada35ce to
684bbd6
Compare
On 32bit platforms there are 7 bits reserved for the unowned retain count. This makes overflow a likely scenario. Implement overflow into the side table. rdar://33495003
aschwaighofer
force-pushed
the
runtime_fix_unowned_retain_overflow
branch
from
684bbd6 to
d8abd2f
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
On 32bit platforms there are 7 bits reserved for the unowned retain count. This
makes overflow a likely scenario. Implement overflow into the side table.
rdar://33495003