Skip to content

[Lexer] Forward declare RawTokenSyntax in 'Lexer.h' #11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2017
Merged

[Lexer] Forward declare RawTokenSyntax in 'Lexer.h' #11292

merged 1 commit into from
Aug 1, 2017

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Aug 1, 2017

Avoids generated Syntax header dependencies.

Supersedes #11289

@rintaro
[Lexer] Forward declare RawTokenSyntax in 'Lexer.h'
7e6f8ac 
So that this doesn't depend on generated Syntax headers.
@rintaro
Copy link
Member Author

rintaro commented Aug 1, 2017

@swift-ci Please smoke test

@harlanhaskins
Copy link
Contributor

This actually removes a bunch of the need for dependencies on swift-syntax-generated-headers for other targets. We should remove those, but this patch LGTM.

@harlanhaskins
Copy link
Contributor

Thanks for this!

@harlanhaskins harlanhaskins merged commit 3bb90dc into swiftlang:master Aug 1, 2017
@harlanhaskins
Copy link
Contributor

⛵

@rintaro rintaro deleted the lex-forwarddecl-rawtokensyntax branch December 5, 2017 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @harlanhaskins