Skip to content

AST: Stricter verifier check for TupleExpr #11298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2017
Merged

AST: Stricter verifier check for TupleExpr #11298

merged 1 commit into from
Aug 2, 2017

Conversation

slavapestov
Copy link
Contributor

No description provided.

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@jrose-apple You added the original verifier check. Any reason it was a subtype relation and not type equality?

@slavapestov
Copy link
Contributor Author

(I guess I'm about to learn once the test suite completes)

@slavapestov slavapestov force-pushed the ast-verifier-strictness branch from c2de297 to 42a999a Compare August 1, 2017 21:54
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor

Apparently it wasn't important after all. Stricter verifier checks are better!

@slavapestov slavapestov merged commit 0b9ad51 into swiftlang:master Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @jrose-apple