Escape all keywords when printing DeclBaseNames #11309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux platform |
|
I'm not sure we can change the API digester, since we have existing digests with unescaped keywords inside Apple. We're just getting away with it with |
|
(SIL part seems fine.) |
|
I agree with Jordan here. For swift-api-digester, using names consistently is more important than precisely; also escaping keywords doesn't give the tool any benefit since users may never read them manually. So I prefer we preserve the existing behavior. |
ahoppen
force-pushed
the
sil-escape-keywords
branch
from
1927337 to
db02b1b
Compare
|
I have removed the changes to swift-api-digester. |
|
@swift-ci Please smoke test |
jrose-apple
approved these changes
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #10965 (comment), escape all keywords when printing
DeclBaseNames for SIL dotted paths or the api-digester and not only "subscript" and "deinit".