Make more String tests run on Linux #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
Documenting a few failed test cases along the way
glessard
force-pushed
the
string-tests
branch
from
a58c11b to
8e8ce7a
Compare
|
I don't know what made the CI tests fail, but I had left a |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
The non-Linux failures don't seem directly related to this PR; should another test be run? |
|
@swift-ci Please test |
tkremenek
added a commit
that referenced
this pull request
Feb 4, 2016
Make more String tests run on Linux.
| checkComparable(expected, lhs, rhs, stackTrace: stackTrace.withCurrentLoc()) | ||
| } | ||
|
|
||
| for test in comparisonTests { |
There was a problem hiding this comment.
Why did you move the loop out of the test? Doesn't the test provide the reference to the test data when it fails?
There was a problem hiding this comment.
Oh, I see -- you added custom XFAILs. Never mind.
There was a problem hiding this comment.
I thought this would be better than duplicating the tests just for xfail cases.
Thanks for reviewing.
|
@glessard Thank you for this! |
This was referenced Feb 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves a number of String-related tests from
test/1_stdlib/NSStringAPI.swift, where they couldn't run because the file requiresobjc_interop.A few test cases have new xfail annotations, related to sort order (https://bugs.swift.org/browse/SR-530) and comparisons involving embedded nulls (https://bugs.swift.org/browse/SR-630).