Filter out 0-length tokens when generating syntax model nodes #11332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves rdar://problem/33601932.
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift::tokenize()withTokenizeInterpolatedStringset totrueproduces an empty string literal token between directly adjacent interpolations, e.g. in"\(1)\(1)". The syntax model relies upon having a string literal token in this position to determine whether the next left paren and preceding right paren are string interpolation anchors or not, but there is no need to to include a corresponding emptySyntaxNodein the syntax model. 0-length syntax nodes don't really make sense and may break assumptions in clientSyntaxModelWalkers.Resolves rdar://problem/33601932.