Skip to content

IRGen: Fix emission of reflection metadata for @objc enums #11341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

slavapestov
Copy link
Contributor

@objc enums lower as their raw type, so should go through the same
code path as imported enums.

Fixes https://bugs.swift.org/browse/SR-5625 and
rdar://problem/33683103.

@objc enums lower as their raw type, so should go through the same
code path as imported enums.

Fixes <https://bugs.swift.org/browse/SR-5625> and
<rdar://problem/33683103>.
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@shahmishal Looks like fallout from disabling LLDB tests in PR testing:

lit.py: /home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/swift-integration-tests/lit.cfg:180: fatal: lldb does not exist!

@rudkx
Copy link
Contributor

rudkx commented Aug 4, 2017

I just saw the same failure here: #11338

@shahmishal
Copy link
Member

I disabled the test, however I noticed Swift(linux-x86_64).Runtime.linux-fatal-backtrace.swift has import lldb (33718631). We will need to XFail or mark it unsupported until we have lldb build fixed (33715252).

@jrose-apple
Copy link
Contributor

But @objc enums should still be able to print their case names, right?

@shahmishal
Copy link
Member

@swift-ci please clean smoke test Linux

@slavapestov
Copy link
Contributor Author

@jrose-apple The remote reflection API does not currently have a mechanism for getting the selected case from an enum value. For now we're just using it to find references inside aggregates (with a hack for single-payload enums, like optionals... and multi-payload enums are just opaque for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants