[code-completion] Fix for-loop sequences containing collection syntax #11502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes various issues with getting no code-completion in top-level
code containing array/dictionary sugar, such as:
```
for x in [<HERE>] {}
for x in [1: 2, <HERE>] {}
```
And also removes the index variable from completions inside the sequence
(it was coming through as a local variable with <<error type>>).
rdar://problem/33884082
|
@swift-ci please smoke test |
| if (!Container.isNull()) { | ||
| Container.get()->dump(); | ||
| } | ||
| Status |= Container; |
There was a problem hiding this comment.
This is causing dumps when building swift and was probably not intentional.
https://ci.swift.org/job/oss-swift-incremental-RA-osx/133/consoleText
There was a problem hiding this comment.
Ooops! Removing via #11508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various issues with getting no code-completion in top-level
code containing array/dictionary sugar, such as:
And also removes the index variable from completions inside the sequence
(it was coming through as a local variable with <>).
rdar://problem/33884082