Skip to content

Osize: Only skip inlining for class methods #11515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2017
Merged

Osize: Only skip inlining for class methods #11515

merged 1 commit into from
Aug 18, 2017

Conversation

aschwaighofer
Copy link
Contributor

This addresses most of the regressions (when comparing O to Osize) from the compat suite and some size saving gains.

@aschwaighofer
Osize: Only skip inlining for class methods
1b7a308 
This addresses most of the regressions from the compat suite and some size
saving gains.
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please smoke test

@aschwaighofer
Copy link
Contributor Author 

Project/platform                           :        O          Osize  Percent
Alamofire/iphoneos/arm64                   :     566069     478057   15.55
Alamofire/iphoneos/armv7                   :     441666     360062   18.48
iOS Example/iOS/arm64                      :      68712      69960   -1.82
iOS Example/iOS/armv7                      :      57296      57060    0.41
Alamofire/iphoneos                         :    1007735     838119   16.83
Alamofire/iphoneos                         :    1007735     838119   16.83
iOS Example/iphoneos                       :     126008     127020   -0.80
AMScrollingNavbar/iphoneos/arm64           :      64008      60644    5.26
AMScrollingNavbar/iphoneos/armv7           :      54052      50532    6.51
AMScrollingNavbar/iphoneos                 :     118060     111176    5.83
Socket/iphoneos/arm64                      :     105045      96925    7.73
Socket/iphoneos/armv7                      :      85373      72389   15.21
Socket/iphoneos                            :     190418     169314   11.08
ChattoApp/iphoneos/arm64                   :     174799     167975    3.90
ChattoApp/iphoneos/armv7                   :     147416     137240    6.90
Chatto/iphoneos/arm64                      :     288767     271654    5.93
Chatto/iphoneos/armv7                      :     234192     215775    7.86
ChattoAdditions/iphoneos/arm64             :     635209     574946    9.49
ChattoAdditions/iphoneos/armv7             :     522390     457335   12.45
Chatto/iphoneos                            :     522959     487429    6.79
ChattoAdditions/iphoneos                   :    1157599    1032281   10.83
ChattoApp/iphoneos                         :     322215     305215    5.28
Chatto/iphoneos                            :     522959     487429    6.79
ChattoAdditions/iphoneos                   :    1157599    1032281   10.83
CleanroomLogger/watchos                    :     149162     136914    8.21
Dollar/macos                               :     192598     160020   16.92
Dwifft/iphoneos/arm64                      :      95300      81488   14.49
Dwifft/iphoneos/armv7                      :      73640      62308   15.39
Dwifft/iphoneos                            :     168940     143796   14.88
IBAnimatable/iphoneos/arm64                :    1831885    1440657   21.36
IBAnimatable/iphoneos/armv7                :    1451691    1102703   24.04
IBAnimatableApp/iphoneos/arm64             :     208827     206287    1.22
IBAnimatableApp/iphoneos/armv7             :     166875     159371    4.50
IBAnimatable/iphoneos                      :    3283576    2543360   22.54
IBAnimatable/iphoneos                      :    3283576    2543360   22.54
IBAnimatableApp/iphoneos                   :     375702     365658    2.67
JSQDataSourcesKit/iphoneos/arm64           :     107686     105506    2.02
JSQDataSourcesKit/iphoneos/armv7           :      83379      80267    3.73
JSQDataSourcesKit/iphoneos                 :     191065     185773    2.77
KeychainAccess/watchos                     :     163960     149736    8.68
Prelude/appletvos                          :      96856      89016    8.09
Prelude_UIKit/appletvos                    :     252361     248633    1.48
ReactiveExtensions/appletvos               :     159359     142163   10.79
ReactiveSwift/appletvos                    :     819507     748742    8.64
Result/appletvos                           :      62529      61358    1.87
Kingfisher/watchos                         :     208324     190868    8.38
Kommander/watchos                          :      53448      40368   24.47
LaunchScreenSnapshot/iphoneos/arm64        :      45484      43371    4.65
LaunchScreenSnapshot/iphoneos/armv7        :      40448      38105    5.79
LaunchScreenSnapshot/iphoneos              :      85932      81476    5.19
ObjectMapper/watchos                       :     173358     145850   15.87
Example/iphoneos/arm64                     :      31870      30614    3.94
Example/iphoneos/armv7                     :      25361      23793    6.18
PanelKit/iphoneos/arm64                    :     142534     135330    5.05
PanelKit/iphoneos/armv7                    :     114962     105594    8.15
Example/iphoneos                           :      57231      54407    4.93
PanelKit/iphoneos                          :     257496     240924    6.44
PanelKit/iphoneos                          :     257496     240924    6.44
PromiseKit/appletvos                       :     271600     235661   13.23
ReLax/appletvos                            :     173035     159515    7.81
ReactiveCocoa/watchos                      :      71840      68742    4.31
ReactiveSwift/watchos                      :     526275     473311   10.06
Result/watchos                             :      37353      35649    4.56
ReactiveSwift/watchos                      :     526163     473199   10.07
Result/watchos                             :      37353      35649    4.56
Realm/watchos                              :    3118785    3118785    0.00
ReSwift/watchos                            :      40534      38162    5.85
RxCocoa/iphoneos/arm64                     :     534869     506467    5.31
RxCocoa/iphoneos/armv7                     :     402525     373731    7.15
RxSwift/iphoneos/arm64                     :     909159     871667    4.12
RxSwift/iphoneos/armv7                     :     653787     616011    5.78
RxCocoa/iphoneos                           :     937394     880198    6.10
RxSwift/iphoneos                           :    1562946    1487678    4.82
RxSwift/appletvos                          :    1109376    1046216    5.69
RxTest/appletvos                           :      87468      76252   12.82
Siesta/macos                               :     632922     547154   13.55
SiestaUI/macos                             :         48         48    0.00
Starscream/appletvos                       :     132204     126940    3.98
SwiftDate/watchos                          :     405367     363609   10.30
SwifterSwift/watchos                       :     311135     296835    4.60

Total                                      :  114532256  110218575    3.77

@aschwaighofer aschwaighofer merged commit e60d71a into swiftlang:master Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aschwaighofer