[ConstraintSolver] Skip performance hacks in presence of unavailable … #11519
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
I have a different idea now of how to solve this problem, i think we should be checking non-generic solution score for certain kinds of conversions (instead of simply if it has been increased or not) which should allow generic to be attempted e.g. if it has forced IUO conversion or a fix or any unavailable overloads, and we should attach best solution score to each |
xedin
force-pushed
the
unavailable-limits-perf-hacks
branch
from
737a924 to
143b6dd
Compare
|
@swift-ci please smoke test |
xedin
force-pushed
the
unavailable-limits-perf-hacks
branch
from
143b6dd to
9345765
Compare
|
@swift-ci please smoke test |
xedin
force-pushed
the
unavailable-limits-perf-hacks
branch
from
9345765 to
5c02cc0
Compare
|
@swift-ci please smoke test |
lib/Sema/CSSolver.cpp
Outdated
| bool hasUnavailableOverloads = score.Data[SK_Unavailable] > 0; | ||
|
|
||
| // Attempt to short-circuit disjunction only if | ||
| // score indicates that there are no unavaible |
There was a problem hiding this comment.
Thanks! And of course I had to make a typo :)
…overloads Limit the scope of the performance hacks which currently exist in the solver even further by disallowing it to skip generic overlaods or stop in case when previous solutions involve unavailable overloads, which otherwise might lead to producing incorrect overall solutions.
xedin
force-pushed
the
unavailable-limits-perf-hacks
branch
from
5c02cc0 to
47353c2
Compare
|
@swift-ci please smoke test |
|
source compatibility suite currently has |
|
@swift-ci please test source compatibility |
|
Ok, looks like it's still only |
…overloads
Limit the scope of the performance hacks which currently exist in the
solver even further by not allowing it to skip generic overlaods or stop
solver in case when previous solutions involve unavailable overloads,
which otherwise might lead to producing incorrect overall solutions.