Skip to content

[sourcekitd] Remove calls to llvm::Initialize* #11658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2017
Merged

[sourcekitd] Remove calls to llvm::Initialize* #11658

merged 1 commit into from
Aug 28, 2017

Conversation

benlangmuir
Copy link
Contributor

  • Explanation: We added some calls to llvm::Initialize functions that turned out to be unnecessary. These bloated the binary size of sourcekitd, and in particular our thin client-side library, taking it from ~350 KB to over 20 MB because it required statically linking in most of LLVM.
  • Scope: Affects binary size of sourcekitd and (theoretically) time to startup.
  • Radar: rdar://problem/31902757
  • Risk: Low; removes unnecessary calls. If they were needed we expect it would have caused test failures in our code-completion PCH tests.
  • Testing: Existing regression tests pass after removal of code.

@akyrtzi
Copy link
Contributor

akyrtzi commented Aug 28, 2017

LGTM!

@benlangmuir
Copy link
Contributor Author

@swift-ci please test

@benlangmuir benlangmuir merged commit 3b7262d into swiftlang:swift-4.0-branch Aug 28, 2017
@benlangmuir benlangmuir deleted the sourcekitd-thinning-4.0 branch August 28, 2017 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@akyrtzi akyrtzi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlangmuir @akyrtzi