Skip to content

[4.0] [PrintAsObjC] Print availability on classes, protocols, and categories #11659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2017
Merged

[4.0] [PrintAsObjC] Print availability on classes, protocols, and categories #11659

merged 1 commit into from
Aug 28, 2017

Conversation

jrose-apple
Copy link
Contributor

  • Explanation: We were getting warnings in generated Objective-C headers now that Clang has availability diagnostics too (-Wpartial-availability and friends). Printing availability on top-level declarations fixes this issue. This change also corrects an issue with availability messages being omitted in certain cases, which should only affect what's shown to the user.
  • Scope: Affects available attributes on Swift declarations exposed to Objective-C.
  • Issue: rdar://problem/33313703
  • Reviewed by: @DougGregor
  • Risk: Low. All of this only affects warnings anyway.
  • Testing: Added regression tests, verified that the original test case now passes.

@jrose-apple
Merge pull request swiftlang#11252 from jrose-apple/PrintAsObjC-avail…
797f0ac 
…ability-fixes

[PrintAsObjC] Print availability on classes, protocols, and categories

rdar://problem/33313703
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 797f0ac

@jrose-apple
Copy link
Contributor Author

jrose-apple commented Aug 28, 2017 •
edited
Loading

TestFoundation/TestURLSession.swift:682: error: TestURLSession.test_simpleUploadWithDelegate : XCTAssertEqual failed: ("0") is not equal to ("16384") -

^ @phausler, in case you're interested.

Not related to this change, so…

@swift-ci Please test Linux

@phausler
Copy link
Contributor

sounds like a network/load hiccup

@jrose-apple
Copy link
Contributor Author

Approved by Ted via email. Merging.

@jrose-apple jrose-apple merged commit 39a6a01 into swiftlang:swift-4.0-branch Aug 28, 2017
@jrose-apple jrose-apple deleted the 4.0-PrintAsObjC-availability-fixes branch August 28, 2017 22:53
DougGregor
DougGregor reviewed Aug 31, 2017
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor left review comments

Assignees

@tkremenek tkremenek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrose-apple @swift-ci @phausler @DougGregor @tkremenek