IRGen: fix statically initialized globals which contain an empty type. #11675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This problem can crash the compiler with an assert or - even worse - in a non assert compiler produce wrong code for reading a global variable.
Scope of Issue: This can only happen if a global variable is a struct or tuple and one of the elements is an empty type (e.g. an empty tuple or empty struct).
Risk: Low. The fix just adds a check for the case where the compiler would have crashed.
Reviewed By: Joe Groff
Testing: There is a regression test for it
Radar: rdar://problem/34123143