Skip to content

[test] Add a test for the tricky circularity in SR-5191 #11685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

jrose-apple
Copy link
Contributor

This was fixed by 897effe in #10707, which I had originally thought would be a no-functionality-change commit because it just made things lazier. Turns out requirement signature deserialization can result in circularity with sufficiently cross-referential conformances.

This isn't exactly a reduced test case because it still depends on subclassing NSObject, which probably means there are hidden dependencies on conforming to standard library protocols. But it's better than nothing.

SR-5191

This was fixed by 897effe, which I had originally thought would be a
no-functionality-change commit because it just made things lazier.
Turns out requirement signature deserialization can result in
circularity with sufficiently cross-referential conformances.

This isn't exactly a reduced test case because it still depends on
subclassing NSObject, which probably means there are hidden
dependencies on conforming to standard library protocols. But it's
better than nothing.

https://bugs.swift.org/browse/SR-5191
@jrose-apple jrose-apple requested a review from DougGregor August 29, 2017 23:17
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor Author

Merging so I can finish putting together the 4.0 PR.

@jrose-apple jrose-apple merged commit f5a6ac9 into swiftlang:master Aug 29, 2017
@jrose-apple jrose-apple deleted the SR-5191 branch August 29, 2017 23:51
jrose-apple added a commit to jrose-apple/swift that referenced this pull request Aug 29, 2017
…1685)

This was fixed by 897effe, which I had originally thought would be a
no-functionality-change commit because it just made things lazier.
Turns out requirement signature deserialization can result in
circularity with sufficiently cross-referential conformances.

This isn't exactly a reduced test case because it still depends on
subclassing NSObject, which probably means there are hidden
dependencies on conforming to standard library protocols. But it's
better than nothing.

https://bugs.swift.org/browse/SR-5191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant