[code-completion] Filter out non-postfix results from inner operators #11695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benlangmuir
commented
Aug 30, 2017
benlangmuir
commented
- Explanation: We are allowing through non-postfix completions when collecting operator completions in a way that can result in non-sensical compound completions like "fooUIColor".
- Scope: Affects code-completion of inner operators on the new code-completion path (codecomplete.open).
- Radar: rdar://problem/34145229
- Risk: Low; just throws out these non-postfix results.
- Testing: Regression tests added.
With broken code you can end up with non-postfix completions when searching for inner operators, which you never want because you end up creating compound results like "fooUIColor". rdar://problem/34145229
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.