Add an Osize option #11720
Merged
Add an Osize option #11720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an size optimization mode ("Osize") which intends to enable some
optimization but targets mainly reduced code size compared to the regular
optimized mode ("O").
rdar://33075751
Enable to run our tests with -Osize
We might be more aggressive here in the future.
This is obviously just a start. Don't inline into thunks and don't inline methods. Start off with half the benefit for removing a call.
This addresses most of the regressions from the compat suite and some size saving gains.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Explanation: These changes add an Osize option and changes to the optimizer guarded by this option: the inliner is tuned down, speculative devirtualization, function signature specialization and array property specialization is turned off. LLVM’s OptimizeForSize attribute is added to functions and LLVM’s noinline attribute is attached to metadata and witness accessor.
• Scope of Issue: Introduction of a new feature
• Reviewed By: Erik Eckstein
• Testing: tested by the test suite
rdar://34194331