[WIP] [ConstraintSolver] Score disjunctions to prune search space #11723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is part 3 (of 3) related to search space pruning, it makes a least 5 "expression to complex" no longer complex but degrades one of the examples we have too, so I need to look into that still. |
|
The problem here is that disjunction score also needs to account how to use disjunctions to split constraint buckets evenly otherwise some of the cases which currently work (just because of the ordering of the type variables and size of the disjunctions) are going to become slow. Since we have |
In each of the constraint component score disjunctions based on how much information do we have about them, the more information we have, the easier it is to prune search space of incorrect branches earlier.
xedin
force-pushed
the
score-disjunctions
branch
from
d80cd86 to
86dcdce
Compare
|
@swift-ci please test source compatibility |
xedin
force-pushed
the
score-disjunctions
branch
from
86dcdce to
4df25d3
Compare
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In each of the constraint component score disjunctions
based on how much information do we have about them, the
more information we have, the easier it is to prune search
space of incorrect branches earlier.