Added swiftpm and other libs to Android toolchain #11870

amraboelela · 2017-09-12T03:23:19Z

These changes will add swift package management tools to the android toolchain, among other libraries and tools

amraboelela · 2017-09-12T03:23:41Z

@milseman Please check this :)

milseman · 2017-09-12T20:46:46Z

@Rostepher, could you review this or let me know who is a more appropriate reviewer for this?

milseman · 2017-09-12T20:46:54Z

@swift-ci please smoke test

milseman · 2017-09-12T22:23:44Z

@swift-ci please smoke test

amraboelela · 2017-09-12T22:26:30Z

Question. When you say @ swift-ci please smoke test, are there humans behind this or is it automatic thing? :)

milseman · 2017-09-12T22:30:44Z

Automatically handled by a bot. There are sometimes issues, of course, which are inherent to the problem of CI.

Rostepher · 2017-09-12T22:33:18Z

If you don't see a build start almost immediately then the CI bot probably didn't get the message.

amraboelela · 2017-09-12T22:49:40Z

Does that mean I can also initiate the test by saying @ swift-ci please smoke test ?

milseman · 2017-09-12T22:50:44Z

@amraboelela It might be limited to those with commit access, to help manage potential load on the bots.

amraboelela · 2017-09-12T22:53:25Z

@swift-ci please smoke test

amraboelela · 2017-09-12T22:54:06Z

Just testing :) so I guess it didn't work from me.

amraboelela · 2017-09-12T23:54:08Z

Oh, the tests actually got started after a while, so maybe anybody can start them.

amraboelela · 2017-09-13T17:48:04Z

@swift-ci please smoke test

amraboelela · 2017-09-13T18:41:14Z

It got stuck at Waiting for status to be reported

milseman · 2017-09-13T20:24:53Z

@swift-ci please smoke test

CodaFi · 2017-09-14T13:58:46Z

Not that I know what I'm taking about, but is it reasonable to constrain the script to only build for armv7e? Shouldn't this be something that's figured out from a target triple instead of hard-coded?

milseman · 2017-09-14T17:04:51Z

@Rostepher could you review this?

compnerd · 2017-09-19T06:22:59Z

@CodaFi android only supports the A class of CPUs AFAIK. The NDK only provides the v7a bits, so I think that bit is reasonable.

Rostepher · 2017-09-19T06:33:22Z

@milseman I'll give this a look over in the morning.

Rostepher

I don't see any issues with this, except for what @CodaFi pointed out with hardcoding the ARM version. I've not had any experience with building for Android yet so take my input with a grain of salt. @gottesmm Do you have any experience with Android builds?

gottesmm · 2017-09-22T20:10:17Z

No. I think @modocache is the best AFAIK.

alblue · 2017-10-13T16:49:17Z

@swift-ci please smoke test

alblue · 2017-10-13T16:50:43Z

@amraboelela note that the swift-ci bot is picky about who it listens to - committers have access to trigger builds but not others. When it says 'waiting for status' it's really waiting for someone else to kick it off on your behalf.

milseman · 2017-10-13T23:14:05Z

@compnerd or @modocache what do you think of this change?

modocache

This is great, thanks!

I believe "armeabi-v7a" is hardcoded in a few spots in the build scripts and testing utilities for Android, so it doesn't bother me that it also is here. Maybe someone could create a task to clean that up and take care of it in a forthcoming pull request?

modocache · 2017-10-14T04:17:22Z

utils/android/README.md

@@ -0,0 +1,14 @@
+
+# Build Android Toolchain


Just a suggestion: I think expanding on what "Android toolchain" means here would help people who have some interest, but don't quite understand what a "toolchain" is, to use the scripts and tools in here. Ideally, I think this README should answer the question: "why would I want to build an Android toolchain?"

xwu · 2017-10-17T05:26:06Z

utils/android/README.md

+
+# Build Android Toolchain
+
+This toolchain will generate the .so and .swiftmodule files of swift standard library and Foundation framework for Android environment, armv7 architecture. Those files are needed when building any swift library to be included in an applciation for Android.


Please capitalize "Swift" and correct the typo in the word "application".
Insert "the" before "Swift standard library" and before "Android environment".

milseman · 2017-10-17T21:15:50Z

@amraboelela, do you want to do those fixes in this PR or a followup? I know it's been open for quite a while, and I have no strong opinions so long as @modocache and @xwu are fine with either.

amraboelela · 2017-10-17T21:44:59Z

@milseman I already did the changes that @modocache and @xwu asked me to do.

milseman · 2017-10-17T22:22:15Z

@swift-ci please smoke test

alblue · 2017-10-18T07:48:06Z

@swift-ci please smoke test

milseman · 2017-10-18T15:00:17Z

@swift-ci please smoke test Linux Platform

xwu · 2017-10-19T02:47:04Z

utils/android/README.md

+
+# Build Android Toolchain
+
+This toolchain will generate the .so and .swiftmodule files of the Swift standard library and Foundation framework for the Android environment, armv7 architecture. Those files are needed when building any swift library to be included in an application for Android.


Please capitalize all instances of "Swift" :)

milseman · 2017-10-19T22:16:19Z

@swift-ci please smoke test

amraboelela · 2017-10-20T17:26:08Z

Did I ruin the smoke test by doing merge from master?

Rostepher · 2017-10-20T18:35:56Z

Any new commits will update the status of the PR and require a new smoke-test run. Same goes for force pushing a git rebase or a new merge commit.

Rostepher · 2017-10-20T18:36:09Z

@swift-ci please smoke test

amraboelela · 2017-10-21T02:06:45Z

Did another merge from master because the Linux smoke test failed.

modocache · 2017-10-21T17:07:50Z

@swift-ci please smoke test

milseman requested a review from Rostepher September 12, 2017 20:46

amraboelela force-pushed the android-build-toolchain2 branch from d7ebf25 to 969645c Compare September 12, 2017 23:52

Rostepher reviewed Sep 21, 2017

View reviewed changes

amraboelela force-pushed the android-build-toolchain2 branch from eec5656 to b88b88c Compare October 12, 2017 03:34

amraboelela mentioned this pull request Oct 13, 2017

Added build-android script swiftlang/swift-corelibs-foundation#1249

Merged

milseman requested review from compnerd and modocache October 13, 2017 23:13

modocache approved these changes Oct 14, 2017

View reviewed changes

amraboelela force-pushed the android-build-toolchain2 branch 3 times, most recently from 2551bb2 to 888bc52 Compare October 16, 2017 17:05

xwu reviewed Oct 17, 2017

View reviewed changes

amraboelela force-pushed the android-build-toolchain2 branch 5 times, most recently from e38f79f to d9ef07a Compare October 17, 2017 16:08

amraboelela force-pushed the android-build-toolchain2 branch from ff6a306 to 0e9f909 Compare October 18, 2017 03:17

xwu reviewed Oct 19, 2017

View reviewed changes

amraboelela force-pushed the android-build-toolchain2 branch from 0e9f909 to eacb632 Compare October 19, 2017 14:29

amraboelela force-pushed the android-build-toolchain2 branch from a4173c1 to 3936714 Compare October 20, 2017 17:23

amraboelela mentioned this pull request Oct 20, 2017

Added Build Android Toolchain section #12530

Merged

Added swiftpm and other libs to Android toolchain

1d75bc8

amraboelela force-pushed the android-build-toolchain2 branch from 30b2470 to 1d75bc8 Compare October 21, 2017 02:05

milseman merged commit edb078f into swiftlang:master Oct 23, 2017

amraboelela deleted the android-build-toolchain2 branch October 23, 2017 03:47


		# Build Android Toolchain

		This toolchain will generate the .so and .swiftmodule files of swift standard library and Foundation framework for Android environment, armv7 architecture. Those files are needed when building any swift library to be included in an applciation for Android.

Added swiftpm and other libs to Android toolchain #11870

Added swiftpm and other libs to Android toolchain #11870

Uh oh!

Conversation

amraboelela commented Sep 12, 2017

Uh oh!

amraboelela commented Sep 12, 2017

Uh oh!

milseman commented Sep 12, 2017

Uh oh!

milseman commented Sep 12, 2017

Uh oh!

milseman commented Sep 12, 2017

Uh oh!

amraboelela commented Sep 12, 2017

Uh oh!

milseman commented Sep 12, 2017

Uh oh!

Rostepher commented Sep 12, 2017

Uh oh!

amraboelela commented Sep 12, 2017

Uh oh!

milseman commented Sep 12, 2017

Uh oh!

amraboelela commented Sep 12, 2017

Uh oh!

amraboelela commented Sep 12, 2017

Uh oh!

amraboelela commented Sep 12, 2017

Uh oh!

amraboelela commented Sep 13, 2017

Uh oh!

amraboelela commented Sep 13, 2017

Uh oh!

milseman commented Sep 13, 2017

Uh oh!

CodaFi commented Sep 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

milseman commented Sep 14, 2017

Uh oh!

compnerd commented Sep 19, 2017

Uh oh!

Rostepher commented Sep 19, 2017

Uh oh!

Rostepher left a comment

Choose a reason for hiding this comment

Uh oh!

gottesmm commented Sep 22, 2017

Uh oh!

alblue commented Oct 13, 2017

Uh oh!

alblue commented Oct 13, 2017

Uh oh!

milseman commented Oct 13, 2017

Uh oh!

modocache left a comment

Choose a reason for hiding this comment

Uh oh!

modocache Oct 14, 2017

Choose a reason for hiding this comment

Uh oh!

xwu Oct 17, 2017

Choose a reason for hiding this comment

Uh oh!

milseman commented Oct 17, 2017

Uh oh!

amraboelela commented Oct 17, 2017

Uh oh!

milseman commented Oct 17, 2017

Uh oh!

alblue commented Oct 18, 2017

Uh oh!

milseman commented Oct 18, 2017

Uh oh!

xwu Oct 19, 2017

Choose a reason for hiding this comment

Uh oh!

milseman commented Oct 19, 2017

Uh oh!

CodaFi commented Sep 14, 2017 •

edited

Loading