Move build-script apply default arguments into separate module
#11882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rostepher
changed the title
build-script apply default arguments into separate module
This was referenced Sep 12, 2017
Merged
…nts module in preparation for the larger argument parsing refactor.
Rostepher
force-pushed
the
move-build-script-apply-defaults
branch
from
fdcd085 to
619855b
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
As soon as the builds for this branch pass I'll merge it, then onwards to #11872! |
|
This broke the build-script on my machine. It can no longer find ninja in /usr/local/bin. What do you need to help debug this? |
|
@davezarzycki I've made a PR to address the issue #11919. I'll have it merged tonight or in the morning, Sorry for the inconvenience. |
|
Can you unsubscribe me from this email service cause I don’t want any
emails from git hub
…On Thu, Sep 14, 2017 at 11:32 AM Ross Bayer ***@***.***> wrote:
@davezarzycki <https://github.com/davezarzycki> I've made a PR to address
the issue #11919 <#11919>. I'll have
it merged tonight or in the morning, Sorry for the inconvenience.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#11882 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQ86b_vQseMcea4728BLdWX66v9Jcs63ks5siMF0gaJpZM4PVPK6>
.
|
|
@tishansteve You can change your email preferences in your Github account settings. I can't do anything about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR moves the
apply_default_argumentslogic out of the mainbuild-scriptcode into thedriver_argumentsmodule in order to better stage for #11872 and eventually #11880. The diff will show that the move was not strictly a copy-paste, the chunk for determining if ninja ought be built requires thetoolchaininformation which only exists in theBuildScriptInvocationclass. I've opted instead to single out that single case and keep it where it was, everything else was moved verbatim.rdar://problem/34336890